Fix/3316/rawtextparser asking twice #3405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ce-bo
reviewed
Nov 16, 2023
ce-bo
reviewed
Nov 16, 2023
...extParser/src/main/kotlin/de/maibornwolff/codecharta/parser/rawtextparser/MetricCollector.kt
Show resolved
Hide resolved
ce-bo
reviewed
Nov 16, 2023
...wTextParser/src/main/kotlin/de/maibornwolff/codecharta/parser/rawtextparser/RawTextParser.kt
Show resolved
Hide resolved
ce-bo
reviewed
Nov 16, 2023
...awTextParser/src/test/kotlin/de/maibornwolff/codecharta/rawtextparser/MetricCollectorTest.kt
Outdated
Show resolved
Hide resolved
ce-bo
reviewed
Nov 16, 2023
ce-bo
reviewed
Nov 21, 2023
ce-bo
approved these changes
Nov 21, 2023
Adjusted the asked question as well as the functions returns to work in interactive mode
Specifically about the file extension option
Can handle multiple file extensions and file extensions starting with a dot
Does not produce an outout file when file extensions could not be found; also updated tests for this
Added warnings when a file extension was not found; also added multiple tests for that
Also changed the assertion used to compare json files
Nereboss
force-pushed
the
fix/3316/rawtextparser-asking-twice
branch
from
9b3152d to
35cb98b
Compare
|
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!
|
|
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust RawTextParsers question about specific file extensions
RawTextParser was asking one questions about regex patterns twice, the 2nd question should have asked about only including specific file extensions, which was adjusted here.
Closes: #3316
Description
Adjusted the asked question to correctly represent what the user is supposed to put in.
Also adjusted how the user input to that question was handled, as it previously broke the parsers result for all inputs other than a single file type. This was done by correctly checking for an empty user input (empty string in interactive mode) and splitting the user input in case multiple file types were put in.
Also included Warnings or Errors in case one of the or all the given file types were not found in the folder.