New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/3348/deselect building reset color #3426

Merged

phanlezz merged 8 commits into main from fix/3348/deselect-building-reset-color

Dec 5, 2023

Collaborator

phanlezz commented Dec 4, 2023 •

edited

Loading

Fix select color not correctly resetting on unselect in delta mode

Closes: #3348

Description

Change defaultDeltaColor to be the true default / backup color for select/unselect (like it is handled in non-delta mode)
Add onclick method to CodeMapBuilding for selection process (avoid override of default value)
- This is necessary because the delta colors get set on existing buildings and not while being constructed (like in non-delta mode)

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

Changes have been manually tested
All TODOs related to this PR have been closed
There are automated tests for newly written code and bug fixes
All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
Documentation (GH-pages, analysis/visualisation READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
CHANGELOG.md has been updated

Screenshots or gifs

phanlezz added 6 commits

December 4, 2023 15:15


          Fix delta color deselect by adding backup WIP

a0c261f


          Fix select color not reset in delta mode

b684564

... By consistent use of default as a backup storage


          Update snapshot for test

da654bc


          Fix typo in pull_request_template

668360d


          Add changelog entry

6e37e97


          Format PR template to fix checkboxes

5342ce1

phanlezz force-pushed the fix/3348/deselect-building-reset-color branch from 4b2c8d5 to 5342ce1 Compare

December 4, 2023 14:16


          Remove unused field

56b996f

Nereboss reviewed

View reviewed changes

visualization/app/codeCharta/ui/codeMap/rendering/codeMapBuilding.ts Outdated Show resolved Hide resolved

Nereboss approved these changes

View reviewed changes

Contributor

Nereboss left a comment

LGTM! 🚀


          Add test and rename methods by review

dc24674

sonarcloud bot commented Dec 5, 2023

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

sonarcloud bot commented Dec 5, 2023

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

86.7% Coverage
0.0% Duplication

phanlezz merged commit 8cb60c1 into main

7 checks passed

phanlezz deleted the fix/3348/deselect-building-reset-color branch

December 5, 2023 10:20

phanlezz mentioned this pull request

fix : add some code to reset the color in delta mode #3368

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet