Fix/2866/ccsh modify behavior 2 #3448
Conversation
fritschldwg
force-pushed
the
fix/2866/ccsh-modify-behavior-2
branch
3 times, most recently
from
1b6002c to
eeed3a4
Compare
|
Open for discussion:
|
|
|
||
| The edges and blacklist entries associated with moved/removed nodes will be altered as well, while all attribute types will be copied. | ||
| Specifying multiple actions in a single command results in only one being performed.\ |
There was a problem hiding this comment.
My suggestion would be to adjust this to "result in only the first action being performed", that way its more clear what the command will do (given we change the implementation to work that way).
There was a problem hiding this comment.
Let's remove this line. I see no argument to keep it. It should be clear from the documentation above.
There was a problem hiding this comment.
The command should fail immediately if there is more than one action specified.
Otherwise it will not be obvious that the command is failing.
It will silently continueing with an unexpected behavior.
...Modifier/src/main/kotlin/de/maibornwolff/codecharta/filter/structuremodifier/ParserDialog.kt
Outdated
Show resolved
Hide resolved
...Modifier/src/main/kotlin/de/maibornwolff/codecharta/filter/structuremodifier/ParserDialog.kt
Outdated
Show resolved
Hide resolved
|
|
||
| The edges and blacklist entries associated with moved/removed nodes will be altered as well, while all attribute types will be copied. | ||
| Specifying multiple actions in a single command results in only one being performed.\ | ||
| Edges and blacklist entries associated with moved or removed nodes will be adjusted, and all attribute types will be copied. |
There was a problem hiding this comment.
Just as an information: Blacklist entries are still part of our latests cc.json structure.
Though, I think we can remove this one as it is not needed anymore. Blacklisted items are stored within a custom view and a user is not able to donwload a modified map with blacklisted pathes anymore since a while.
...Modifier/src/main/kotlin/de/maibornwolff/codecharta/filter/structuremodifier/ParserDialog.kt
Outdated
Show resolved
Hide resolved
...Modifier/src/main/kotlin/de/maibornwolff/codecharta/filter/structuremodifier/ParserDialog.kt
Outdated
Show resolved
Hide resolved
...Modifier/src/main/kotlin/de/maibornwolff/codecharta/filter/structuremodifier/ParserDialog.kt
Outdated
Show resolved
Hide resolved
...Modifier/src/main/kotlin/de/maibornwolff/codecharta/filter/structuremodifier/ParserDialog.kt
Outdated
Show resolved
Hide resolved
...ier/src/main/kotlin/de/maibornwolff/codecharta/filter/structuremodifier/StructureModifier.kt
Outdated
Show resolved
Hide resolved
...ier/src/main/kotlin/de/maibornwolff/codecharta/filter/structuremodifier/StructureModifier.kt
Outdated
Show resolved
Hide resolved
...c/main/kotlin/de/maibornwolff/codecharta/filter/structuremodifier/StructureModifierAction.kt
Outdated
Show resolved
Hide resolved
...c/main/kotlin/de/maibornwolff/codecharta/filter/structuremodifier/StructureModifierAction.kt
Outdated
Show resolved
Hide resolved
...kotlin/de/maibornwolff/codecharta/filter/structuremodifier/ExtractFirstOptionPreprocessor.kt
Outdated
Show resolved
Hide resolved
Only added for the set-root option, needs to be adjusted for the others
This reverts commit 3ad1d26.
fritschldwg
force-pushed
the
fix/2866/ccsh-modify-behavior-2
branch
from
152578e to
6f413e9
Compare
|
|
Fix/2866/ccsh modify behavior 2
Issue: #2866
Description
Descriptive pull request text, answering:
Definition of Done
A PR is only ready for merge once all the following acceptance criteria are fulfilled: