Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin explorer menu #2788 #3459

Merged
merged 5 commits into from
Jan 8, 2024
Merged

Pin explorer menu #2788 #3459

merged 5 commits into from
Jan 8, 2024

Conversation

fritschldwg
Copy link
Contributor

@fritschldwg fritschldwg commented Jan 5, 2024

Pin explorer menu #2788

Closes: #2788

Description

Descriptive pull request text, answering:

  • File explorer can be pinned
  • Map can be moved when file explorer is pinned

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Copy link
Collaborator

@phanlezz phanlezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Please remove the import rename in visualization/app/codeCharta/state/store/appSettings/appSettings.reducer.ts

@fritschldwg fritschldwg enabled auto-merge (rebase) January 8, 2024 09:21
Copy link

sonarcloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Visualization'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Analysis'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@fritschldwg fritschldwg merged commit 65d19e3 into main Jan 8, 2024
7 checks passed
@fritschldwg fritschldwg deleted the feature/2788/pin-explorer-menu branch January 8, 2024 09:29
phanlezz added a commit that referenced this pull request Jan 19, 2024
Change className to NgClass to avoid overriding styling classes when intilized #3459
phanlezz added a commit that referenced this pull request Jan 22, 2024
Change className to NgClass to avoid overriding styling classes when intilized #3459
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can I fix the file/node explore menu?
2 participants