Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix number of labels not saved #3339 #3461

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

fritschldwg
Copy link
Contributor

@fritschldwg fritschldwg commented Jan 9, 2024

Fix number of labels not saved #3339

Closes: #3339

Description

Descriptive pull request text, answering:

  • Number of top-labels get applied correctly when applying a custom config
  • Build-height gets applied correctly

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Copy link

sonarcloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Visualization'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Analysis'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@Nereboss Nereboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@fritschldwg fritschldwg merged commit 95f9691 into main Jan 9, 2024
7 checks passed
@fritschldwg fritschldwg deleted the fix/3339/number-of-labels-not-saved branch January 9, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number of shown lables is not recovered when applying a custom view
3 participants