Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/1234/keep-label-on-selection #3465

Merged
merged 7 commits into from
Jan 12, 2024

Conversation

Nereboss
Copy link
Contributor

@Nereboss Nereboss commented Jan 10, 2024

Add label for the currently selected building

Issue: #1234

Description

Descriptive pull request text, answering:

  • What problem/issue are you fixing?
  • What does this PR implement and how?

Makes the label that appears when hovering over a building stay while the building is selected

We should not close the connected issue as it had some other ideas that could be implemented later

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Screenshots or gifs

when clicking on a building and rotating the map after (while the cursor is outside of the map), the line from the building to the label was not drawn to the correct label location
@fritschldwg fritschldwg force-pushed the feature/1234/keep-label-on-selection branch from 90fe3ea to f478667 Compare January 12, 2024 13:27
Copy link
Contributor

@fritschldwg fritschldwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@fritschldwg fritschldwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fritschldwg fritschldwg enabled auto-merge (rebase) January 12, 2024 13:35
Copy link

sonarcloud bot commented Jan 12, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Visualization'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
85.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jan 12, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Analysis'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@fritschldwg fritschldwg merged commit e56f312 into main Jan 12, 2024
7 checks passed
@fritschldwg fritschldwg deleted the feature/1234/keep-label-on-selection branch January 12, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants