Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech/3733/view encapsulation dialogs #3736

Merged
merged 15 commits into from
Sep 13, 2024

Conversation

LisaWalter90
Copy link
Collaborator

@LisaWalter90 LisaWalter90 commented Sep 12, 2024

Enable View Encapsulation in Dialogs

Issue/Closes: #3733

Description

Enable View Encapsulation for Dialogs

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

@polina-schoenfeld-mw polina-schoenfeld-mw enabled auto-merge (squash) September 13, 2024 08:26
Copy link

sonarcloud bot commented Sep 13, 2024

Copy link

sonarcloud bot commented Sep 13, 2024

@polina-schoenfeld-mw polina-schoenfeld-mw merged commit 2f9a552 into main Sep 13, 2024
7 checks passed
@polina-schoenfeld-mw polina-schoenfeld-mw deleted the tech/3733/view-encapsulation-dialogs branch September 13, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable View Encapsulation for Dialogs
2 participants