Update signature generator to new branding #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdmoore
reviewed
Dec 17, 2024
| src={brandLogo.link} | ||
| alt={brandLogo.alt} | ||
| /> | ||
| <img src={brandLogo.link} alt={brandLogo.alt} /> |
There was a problem hiding this comment.
We probably want width and height, pretty sure that was deliberate for email clients (including style and explicit width/height).
robdmoore
reviewed
Dec 17, 2024
| @@ -199,7 +191,6 @@ const Signature = (props) => { | |||
| <td | |||
| style={{ | |||
| color: '#4a4a4a', | |||
| fontFamily: '"Segoe UI", Helvetica, Arial, sans-serif', | |||
There was a problem hiding this comment.
Deliberately removed? Might need to be explicit for email clients.
|
We need to use a non-gradient version of the logo because we don't want the gradient on a whitebackground (the yellow part of the gradient gets washed out). Side-note: I can't remember how this setup is affected by light mode / dark mode in email clients? |
robdmoore
reviewed
Dec 17, 2024
| @@ -18,7 +18,6 @@ const RepliesAndForwards = (props) => { | |||
| } = props; | |||
| const styleObj = { | |||
| color: 'black', | |||
| fontFamily: '"Segoe UI", Helvetica, Arial, sans-serif', | |||
There was a problem hiding this comment.
We probably want to keep all of the explicit fonts given email clients.
Drop segoe though, keep helvetica, arial, sans
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.