Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ivanchuk navbar - broken coloring #6983

Closed
himdel opened this issue Apr 16, 2020 · 7 comments
Closed

Ivanchuk navbar - broken coloring #6983

himdel opened this issue Apr 16, 2020 · 7 comments
Assignees
Labels

Comments

@himdel
Copy link
Contributor

himdel commented Apr 16, 2020

ivanchuk

Cc @epwinchell

That's not intentional, right?
The violet navbar that abruptly stops and changes into the usual blue gradient.

@himdel
Copy link
Contributor Author

himdel commented Apr 16, 2020

clue: it's not present in lower resolutions, halfscreen has the blue gradient all the way,
but full 1920 width breaks this way

@epwinchell
Copy link
Contributor

@himdel That's a bug

@chessbyte
Copy link
Member

@epwinchell is this fixed on jansa?

@epwinchell
Copy link
Contributor

epwinchell commented Jul 6, 2020

@chessbyte If I recall, this was an Ivanchuk only bug. @himdel can confirm.

@himdel
Copy link
Contributor Author

himdel commented Jul 7, 2020

It was definitely an ivanchuk only bug when we planned to have the new menus in jansa.

That didn't happen.

Jansa is different because of #6637,
but the actual color constants in jansa are the ones #6990 changed from.

I'll try to get a working jansa to test this :)

@himdel
Copy link
Contributor Author

himdel commented Jul 7, 2020

So,
ivanchuk: fixed (#6990)
jansa: not a problem (likely #6637)
master: no navbar (#6963)

@himdel himdel closed this as completed Jul 7, 2020
@himdel
Copy link
Contributor Author

himdel commented Jul 7, 2020

jansa-1-beta-1 (small):

20200707151922

jansa-1-beta-1 (large):

20200707152229

(There is an issue - the navbar won't adapt to smaller resolutions, but that's not this issue, or a regression.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants