Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG-General] Terminal output not formatted and uses ASCII in windows #552

Closed
naveen521kk opened this issue Oct 15, 2020 · 7 comments · Fixed by #573
Closed

[BUG-General] Terminal output not formatted and uses ASCII in windows #552

naveen521kk opened this issue Oct 15, 2020 · 7 comments · Fixed by #573
Labels
pr:bugfix Bug fix for use in PRs solving a specific issue:bug

Comments

@naveen521kk
Copy link
Member

Describe the bug
I am on Windows and command prompt and I cd into example_scenes directory and run

manim basic.py

and I get a output like below.
teminal-format
I should get in green colour though.

To Reproduce
Just running the one in example_scene in enough.

Expected behavior
The ill formatted thing should be in green colour.

Logs

Terminal output (Screenshots acceptable)

teminal-format

System Specifications

System Details
  • OS (with version, e.g Windows 10 v2004 or macOS 10.15 (Catalina)): Windows 7
  • Python version (python/py/python3 --version): 3.8
@naveen521kk naveen521kk added the pr:bugfix Bug fix for use in PRs solving a specific issue:bug label Oct 15, 2020
@huguesdevimeux
Copy link
Member

Isn't rich's fault ?

@naveen521kk
Copy link
Member Author

Yeah it is rich. What we can do is to lock a stable version say v5. I know it works correctly on v5 but not on v8.

@huguesdevimeux
Copy link
Member

That's a shame.
Maybe we should open an issue on rich's repo and lock to a stable version, as you said.

@naveen521kk
Copy link
Member Author

Done Textualize/rich#393

Also, I will make a PR to make sure we use rich version<=7.0.0.

@naveen521kk naveen521kk mentioned this issue Oct 19, 2020
1 task
@naveen521kk
Copy link
Member Author

Fixed in rich v9.0.1 but anyhow I am gonna wait till the version is locked by #573

@huguesdevimeux
Copy link
Member

I am gonna wait till the version is locked by

What do you mean by that ?

@naveen521kk
Copy link
Member Author

What do you mean by that ?

We should force installation of rich to ^6.0.0 and not any version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:bugfix Bug fix for use in PRs solving a specific issue:bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants