Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The param in on_runtime_upgrade has been changed from bool to enum UpgradeCheckSelect #993

Open
Dengjianping opened this issue Jan 17, 2023 · 0 comments
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-runtime Area: Issues and PRs related to Runtimes C-enhancement Category: An issue proposing an enhancement or a PR with one L-changed Log: Issues and PRs related to changes T-runtime Team: Relevant for the Runtime Team

Comments

@Dengjianping
Copy link
Contributor

It's a breaking change, but we will know if manta includes this update.

paritytech/substrate#13045

- fn on_runtime_upgrade(checks: bool) -> (Weight, Weight)
+ fn on_runtime_upgrade(checks: frame_try_runtime::UpgradeCheckSelect) 
@Dengjianping Dengjianping added C-enhancement Category: An issue proposing an enhancement or a PR with one A-calamari Area: Issues and PRs related to the Calamari Runtime A-runtime Area: Issues and PRs related to Runtimes T-runtime Team: Relevant for the Runtime Team L-changed Log: Issues and PRs related to changes labels Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-runtime Area: Issues and PRs related to Runtimes C-enhancement Category: An issue proposing an enhancement or a PR with one L-changed Log: Issues and PRs related to changes T-runtime Team: Relevant for the Runtime Team
Projects
None yet
Development

No branches or pull requests

1 participant