feat(metrics): added collectMetricsExpressMiddleware and deprecated defaultMetricsMiddleware #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
syncush
commented
Jul 7, 2023
syncush
commented
| Question | Answer |
|---|---|
| Bug fix | ✖ |
| New feature | ✔ |
| Breaking change | ✖ |
| Deprecations | ✔ |
| Documentation | ✖ |
| Tests added | ✖ |
| Chore | ✖ |
…efaultMetricsMiddleware
syncush
changed the title
CptSchnitz
requested changes
Aug 3, 2023
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@map-colonies/telemetry", | |||
| "version": "5.0.0", | |||
| "version": "5.1.13", | |||
src/metrics/middleware/metrics.ts
Outdated
Comment on lines
7
to
19
| const deconstructSemver = (semverString: string): { major: string; minor: string; patch: string; prerelease: string; build: string } | null => { | ||
| const match = /^(\d+)(?:\.(\d+))?(?:\.(\d+))?(?:-([\w-]+))?(?:\+([\w-]+))?/i.exec(semverString); | ||
| if (!match) { | ||
| return null; | ||
| } | ||
| return { | ||
| major: match[1], | ||
| minor: match[2], | ||
| patch: match[3], | ||
| prerelease: match[4], | ||
| build: match[5], | ||
| }; | ||
| }; |
There was a problem hiding this comment.
move to a common util area
src/metrics/middleware/metrics.ts
Outdated
|
|
||
| export function collectMetricsExpressMiddleware(options: Partial<Opts>): promBundle.Middleware { | ||
| const pacakgeInfo = loadPackageInfo(); | ||
| const defaultOpts: Opts = { |
There was a problem hiding this comment.
maybe upgrade typescript version and try the satisfy keyword
src/metrics/middleware/metrics.ts
Outdated
| ...(options.labels ? options.labels : {}), | ||
| }; | ||
| register.setDefaultLabels(mergedLabels); | ||
| if (meregedOptions.collectNodeMetrics) { |
syncush
force-pushed
the
collect-up-and-express-metrics
branch
from
33d4445 to
4306a9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.