Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcut & context menu item to toggle fullscreen mode #201

Closed
Malvoz opened this issue Nov 4, 2020 · 1 comment
Closed

Keyboard shortcut & context menu item to toggle fullscreen mode #201

Malvoz opened this issue Nov 4, 2020 · 1 comment

Comments

@Malvoz
Copy link
Member

Malvoz commented Nov 4, 2020

As suggested in #18 (comment), it'd be great to have a context menu item to toggle fullscreen mode.

IMO it is a highly valuable feature. It should be available even if the author chooses to disable the control in the UI using controlslist="nofullscreen" (disabling a control does not disable its corresponding feature, per the spec).

I believe the conventional keyboard shortcut for fullscreen is F, which would clash with the "Forward (F)" menu item. 🤔 In the gaming world it is not uncommon to navigate (e.g. move a character) using the WASD keys, so maybe that's something the Back/Forward/Reload items could use instead? 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants