Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse attribution behind a control #216

Closed
Malvoz opened this issue Dec 1, 2020 · 4 comments
Closed

Collapse attribution behind a control #216

Malvoz opened this issue Dec 1, 2020 · 4 comments

Comments

@Malvoz
Copy link
Member

Malvoz commented Dec 1, 2020

There are usability issues with the attribution (some of which are mostly apparent on small screens/in small sized maps).

Problems

Here's a default size map with added opacity to the attribution container to demonstrate:

  1. Controls may be hidden behind the attribution (means we fail SC 2.4.7 Focus Visible):

    attribution-z-index

  2. There are no constraints on the element containing the attribution links, which may result in the following depending on the amount of layer sources and/or the map element's size:

    attribution-overload

  3. Sensory overload

    • Visual
    • Auditory (screen readers announce everything in the attribution on page load because it is visible)
  4. Each attribution link adds to the amount of Tab key presses required to sequentially navigate past the map.

Potential solution

Collapse attribution behind a control, like MapBox does:

toggle-attribution

Collapsing attribution may have several benefits:

  • There's no visible Layout Shift (so does not contribute to the Cumulative Layout Shift) when populating the attribution container with attributions after fetching layer sources.

  • Improves Perceived Performance.

  • Mitigates sensory overload for some users.

  • Less Tab key presses required to sequentially navigate past the map.

@prushforth

This comment has been minimized.

@Malvoz

This comment has been minimized.

@prushforth
Copy link
Member

How persnickety would Web Platform Tests be about the UI to the attribution control? I like the approach MapBox takes, but some browsers might like to be more explicit.

@Malvoz Malvoz changed the title Adaptive UI: (conditionally) hide attribution behind a control? Collapse attribution behind a control Jul 30, 2021
@Malvoz Malvoz mentioned this issue Dec 21, 2021
2 tasks
@AliyanH
Copy link
Member

AliyanH commented Sep 22, 2023

implemented in #815

@AliyanH AliyanH closed this as completed Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants