Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChannelReader #145

Open
Odonno opened this issue Apr 3, 2024 · 1 comment
Open

ChannelReader #145

Odonno opened this issue Apr 3, 2024 · 1 comment

Comments

@Odonno
Copy link
Contributor

Odonno commented Apr 3, 2024

Hello @Marfusios

I am just curious about using and exposing a ChannelReader instead of an Observable to consume received data. I understand the multiple benefits that Rx.NET offers, I only have some questions:

  • Have you tried to make the change already?
  • I am also curious about the performance impact of that change.
  • I suppose it won't have a huge breaking change as you can transform an IAsyncEnumerable into an Observable, still providing the same API experience

Thank you.

@Odonno
Copy link
Contributor Author

Odonno commented Apr 9, 2024

Also curious if we should add .ConfigureAwait(false) here

result = await client.ReceiveAsync(buffer, token);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant