Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression of #12418 ([2.0.x] Filament Runout Sensor sporadic false positive when using FILAMENT_RUNOUT_DISTANCE_MM > 0) #12660

Closed
ghost opened this issue Dec 17, 2018 · 2 comments

Comments

@ghost
Copy link

ghost commented Dec 17, 2018

Please refer to issue #12418 ([2.0.x] Filament Runout Sensor sporadic false positive when using FILAMENT_RUNOUT_DISTANCE_MM > 0), which I have reopened. After some testing I have identified the point in time during the last month when this regression occurred. The bug is back to due to a regression introduced by commit #12547 (Add poll_runout_states, which returns 1 for runouts)

I am getting the invalid runout event immediately after the print process begins extruding, and the event occurs repeatedly immediately from then on.

Prior to #12547, no problem. After #12547: Problem occurs. I have tested these two time-points on my printer.

@ghost
Copy link
Author

ghost commented Dec 19, 2018

Ok, I found the problem: The value of FIL_RUNOUT_INVERTING is now inverted due to this commit. I used to use false, I now had to set it to true. I think this corresponds better to the actual situation in my printer: The switch pulls down to GND.

@ghost ghost closed this as completed Dec 19, 2018
@github-actions
Copy link

github-actions bot commented Jun 2, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants