Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Z_SAFE_HOMING_X_POINT no longer allowed outside of print bed. #16943

Closed
marciot opened this issue Feb 24, 2020 · 1 comment
Closed

[BUG] Z_SAFE_HOMING_X_POINT no longer allowed outside of print bed. #16943

marciot opened this issue Feb 24, 2020 · 1 comment

Comments

@marciot
Copy link
Contributor

marciot commented Feb 24, 2020

Currently if the Z_SAFE_HOMING_X_POINT or Z_SAFE_HOMING_Y_POINT is outside of the print bed, as it is on LulzBot TAZ printers, the assertion will fail. This regression was introduced by commit 0fd0554. I do not think it makes sense to have Z_SAFE_HOMING be restricted to points within the bed. In the case of the TAZ, it needs to reach a button besides the print bed, and in the case of the LulzBot Bio, it is used to position the needle outside of the bed so that it can the axis deep enough to trigger a Z_MIN without crushing the needle.

Instead of:

#if ENABLED(Z_SAFE_HOMING)
  static_assert(WITHIN(Z_SAFE_HOMING_X_POINT, X_MIN_BED, X_MAX_BED), "Z_SAFE_HOMING_X_POINT can't be reached by the nozzle.");
  static_assert(WITHIN(Z_SAFE_HOMING_Y_POINT, Y_MIN_BED, Y_MAX_BED), "Z_SAFE_HOMING_Y_POINT can't be reached by the nozzle.");
#endif

I propose:

#if ENABLED(Z_SAFE_HOMING)
  static_assert(WITHIN(Z_SAFE_HOMING_X_POINT,X_MIN_POS, X_MAX_POS), "Z_SAFE_HOMING_X_POINT can't be reached by the nozzle.");
  static_assert(WITHIN(Z_SAFE_HOMING_Y_POINT,Y_MIN_POS, Y_MAX_POS), "Z_SAFE_HOMING_Y_POINT can't be reached by the nozzle.");
#endif
@github-actions
Copy link

github-actions bot commented Jul 3, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants