[BUG] "Error:Probing Failed" is sent over serial even if G29_RETRY_AND_RECOVER is enabled

[o-nix]

STR:

• G29_RETRY_AND_RECOVER is enabled and G29_MAX_RETRIES set to 3, G29_HALT_ON_FAILURE is disabled
• OctoPrint is running and connected, no extra plugins for host commands or error handling
• Start a G29 routine
• When the first probe is failed, then OctoPrint sends M112 immediately

ER: G29 routine is restarted

AR: the printer is halted

FIX: lift probe error logic on the layer above by commenting or guarding the following line

Marlin/Marlin/src/module/probe.cpp

Line 760 in 0518dec

SERIAL_ERROR_MSG(STR_ERR_PROBING_FAILED);

[thinkyhead]

Is Octoprint configured to panic when it sees the word "Error"? If so, try disabling that option.

[o-nix]

@thinkyhead I see that SERIAL_ERROR_MSG is used in kill() as well, so it seems it is the only "standard" way to understand, that the printer halted itself.

[o-nix]

@thinkyhead BTW this is the OctoPrint's setting you mentioned, "Disconnect" and "Send M112" are set by default

[boelle]

@o-nix still an issue?

[o-nix]

@boelle uhm, of course. Wrong error reporting logic. I overrided it manually by commenting the line inmy local Marlin sources.

[o-nix]

So, I confirmed that it is still an issue and you are closing it?
Would you prefer having a PR from me with the commented line?

[boelle]

yes please, we welcome PR's

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.