Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Override CASE_LIGHT_PIN not working #17912

Closed
Fixx opened this issue May 7, 2020 · 5 comments
Closed

[BUG] Override CASE_LIGHT_PIN not working #17912

Fixx opened this issue May 7, 2020 · 5 comments

Comments

@Fixx
Copy link

Fixx commented May 7, 2020

Uncommenting and defining a PIN number not working via option //#define CASE_LIGHT_PIN in Configuration_adv. I need to edit board's pin file, same pin number works that way.
Configuration.txt
Configuration_adv.txt
pins_RUMBA.txt

@randellhodges
Copy link
Contributor

randellhodges commented May 7, 2020

For what board? You'll need to add your config files, pin file, what version of Marlin are you using, etc, etc.

I am using it without problems on about a month old pull of bugfix.

@Fixx
Copy link
Author

Fixx commented May 7, 2020

I didn't want to clutter this topic with config files as issue is pretty basic. I'm using RUMBA with latest 2.0.x bugfix, but this was always the case since I added case light, like 6 months. I'm using Heater 2 output as caselight: pin 6.

@randellhodges
Copy link
Contributor

randellhodges commented May 7, 2020

You have //#define CASE_LIGHT_PIN 6 . If you have the // in front of it, that comments it out so it isn't used. Remove the definition from your pins and then remove the // from it inside your Configuration_adv file and try it.

Edit: I see you specifically mentioned that in your original post, but my mind overlooked that and it wasn't until I saw it in your file that my brain actually processed what you said.

@thinkyhead
Copy link
Member

thinkyhead commented May 7, 2020

Fixed in 6be76af

@github-actions
Copy link

github-actions bot commented Jul 7, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants