Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] PR #18490 breaks PRINTER_EVENT_LEDS and M150 without new "I" option. #18543

Closed
ManuelMcLure opened this issue Jul 5, 2020 · 4 comments
Closed

Comments

@ManuelMcLure
Copy link
Contributor

Bug Description

After PR #18490, M150 without the new I option does nothing, and PRINTER_EVENT_LEDS no longer works.

My Configurations

Configuration_adv.zip

Steps to Reproduce

  • Use the above configuration (adjust Neopixel settings for your specific printer).
  • Execute M150 U255 - all Neopixels should light up bright green, but they do not.
  • Execute M150 I99 U255 - now all Neopixels should light up.
  • Heat up bed with M190 - PRINTER_EVENT_LEDS should operate but does not.

It looks like the PR broke Neopixels except for M150 with the I option specified.

Additional Information

Should

if (get_neo_index() < 0) { 

be

if(get_neo_index() >= 0) {

?

@ellensp
Copy link
Contributor

ellensp commented Jul 5, 2020

Confirmed its broken, looks like thinkyhead broke it when he changed index to support -1

@ellensp
Copy link
Contributor

ellensp commented Jul 5, 2020

Your fix is correct.

@ManuelMcLure
Copy link
Contributor Author

Created PR #18544.

@ellensp ellensp closed this as completed Jul 6, 2020
@github-actions
Copy link

github-actions bot commented Sep 4, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants