Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] No longer possible to have a probe which triggers above the nozzle #20411

Closed
c3D-Dan opened this issue Dec 9, 2020 · 6 comments · Fixed by #20344
Closed

[BUG] No longer possible to have a probe which triggers above the nozzle #20411

c3D-Dan opened this issue Dec 9, 2020 · 6 comments · Fixed by #20344

Comments

@c3D-Dan
Copy link

c3D-Dan commented Dec 9, 2020

Using latest bugfix 2.x

From Sanity check
static_assert(sanity_nozzle_to_probe_offset.z <= 0.25,
"Are you sure your Probe triggers above the nozzle? Set a negative Z value in the NOZZLE_TO_PROBE_OFFSET.");

Yes I am sure my probe triggers above the nozzle. This would be true with any configuration where the nozzle moves out of the way to expose a probe which is above the nozzle height. Forcing users into specific probe configurations seems counter productive. Im all up for a warning or notice in this regard, but not a compilation error.

For the moment, I have commented the offending line in SanityCheck.h

and relevant settings from configuration.h
#define NOZZLE_TO_PROBE_OFFSET { 0, 0, 7.0 } //My nozzle is 7mm lower than my probe.

@sjasonsmith
Copy link
Contributor

There is a pull request open related to this: #20344

Could you describe what your hardware is like, to help educate us on examples where this may be used? Links or pictures showing the setup would be helpful as well.

In the future, please be sure to adhere to the template provided when filing a bug report, including providing your configuration files. That consistency makes it much easier for people who are triaging and debugging issues.

@sjasonsmith sjasonsmith linked a pull request Dec 9, 2020 that will close this issue
@sjasonsmith
Copy link
Contributor

@c3D-Dan please post your configuration files. We can use them to help us create a test case to avoid breaking configurations such as yours in the future.

@sjasonsmith
Copy link
Contributor

Please test again with the latest bugfix, and confirm whether your problem is solved.

@c3D-Dan
Copy link
Author

c3D-Dan commented Dec 9, 2020

Sure thing. I will tomorrow morning. On my phone now.

In reply to your question about what hardware:
http://Cultivate3D.com specifically look at the sections on “Medusa”.

@sjasonsmith
Copy link
Contributor

I am closing that as presumably this has been fixed. Please reply back if that is not true after your testing.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants