Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Compile error MKS TinyBee with MKS Mini 12864 V3 #23561

Closed
wirebeard opened this issue Jan 19, 2022 · 5 comments
Closed

[BUG] Compile error MKS TinyBee with MKS Mini 12864 V3 #23561

wirebeard opened this issue Jan 19, 2022 · 5 comments
Labels
Bug: Confirmed ! C: LCD & Controllers T: HAL & APIs Topic related to the HAL and internal APIs.

Comments

@wirebeard
Copy link

Did you test the latest bugfix-2.0.x code?

Yes, and the problem still exists.

Bug Description

Cant compile Marlin firmware for MKS TinyBee motherboard and graphical LCD MKS Mini 12864 v3 with Neopixel RGB backlight

.pio/build/mks_tinybee/firmware.elf
.pio/build/mks_tinybee/src/src/lcd/dogm/u8g_dev_uc1701_mini12864_HAL.cpp.o:(.data.u8g_dev_uc1701_mini12864_HAL_2x_hw_spi+0x8): undefined reference to `u8g_eps_hw_spi_fn(_u8g_t*, unsigned char, unsigned char, void*)'

Bug Timeline

After added in release 2.0.9.3 MKS TinyBee

Expected behavior

Compile firmware

Actual behavior

Compile error

Steps to Reproduce

  1. Download Marlin 2.0.9.3 (current)
  2. Edit Configuration.h to uncomment #define MKS_MINI_12864_V3; #define NEOPIXEL_LED
  3. Attempt to compile in platformio

Version of Marlin Firmware

2.0.9.3

Printer model

No response

Electronics

Motherboard MKS TinyBee

Add-ons

LCD MKS Mini 12864 V3

Bed Leveling

No response

Your Slicer

No response

Host Software

No response

Additional information & file uploads

Marlin compile error
MKS_TinyBee.zip

@ellensp
Copy link
Contributor

ellensp commented Jan 19, 2022

Orriginal MKS firmware on https://github.com/makerbase-mks/MKS-TinyBee also fails to compile if you enable MKS_MINI_12864_V3

@ellensp
Copy link
Contributor

ellensp commented Jan 19, 2022

You need to edit 1 file and add another missing file from MKS with edits.

Here is the diff for the edit on src/lcd/dogm/HAL_LCD_com_defines.h

diff --git a/Marlin/src/lcd/dogm/HAL_LCD_com_defines.h b/Marlin/src/lcd/dogm/HAL_LCD_com_defines.h
index a30dd4ca17..fac76b89c5 100644
--- a/Marlin/src/lcd/dogm/HAL_LCD_com_defines.h
+++ b/Marlin/src/lcd/dogm/HAL_LCD_com_defines.h
@@ -57,6 +57,11 @@
     #define U8G_COM_HAL_SW_SPI_FN     u8g_com_std_sw_spi_fn
     #define U8G_COM_HAL_HW_SPI_FN     u8g_com_stm32duino_hw_spi_fn
 
+  #elif defined(ESP32)
+
+  uint8_t u8g_eps_hw_spi_fn(u8g_t *u8g, uint8_t msg, uint8_t arg_val, void *arg_ptr);
+  #define U8G_COM_HAL_HW_SPI_FN     u8g_eps_hw_spi_fn
+
   #elif defined(__AVR__)
 
     uint8_t u8g_com_HAL_AVR_sw_sp_fn(u8g_t *u8g, uint8_t msg, uint8_t arg_val, void *arg_ptr);

Unzip this file add into Mrlin/src/HAL/ESP32/u8g_esp32_spi.cpp
u8g_esp32_spi.zip

This compiles, I have no way to test it,
It has a few warnings that relaly need to be looked at also..

@ellensp
Copy link
Contributor

ellensp commented Jan 19, 2022

Is now a PR awaiting review and merge

@thisiskeithb
Copy link
Member

#23562 has been merged.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug: Confirmed ! C: LCD & Controllers T: HAL & APIs Topic related to the HAL and internal APIs.
Projects
None yet
Development

No branches or pull requests

3 participants