Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Freeze feature doesn't work #24662

Closed
1 task done
orfeasv opened this issue Aug 21, 2022 · 2 comments
Closed
1 task done

[BUG] Freeze feature doesn't work #24662

orfeasv opened this issue Aug 21, 2022 · 2 comments

Comments

@orfeasv
Copy link

orfeasv commented Aug 21, 2022

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

Freeze feature should halt all stepper motion when freeze pin is triggered. It worked fine in the previous version I had (2.0.9.3).

Bug Timeline

Updating from 2.0.9.3 to 2.1.1

Expected behavior

When freeze pin receives LOW input (Z endstop switch is closed) all stepper movements should stop.

Actual behavior

All stepper movements continue to work as if freeze pin never changed state.

Steps to Reproduce

No response

Version of Marlin Firmware

2.1.1

Printer model

Anet A8

Electronics

BTT SKR V1.4 Turbo

Add-ons

No response

Bed Leveling

No response

Your Slicer

No response

Host Software

OctoPrint

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

Problem was solved by changing:

#if HAS_FREEZE_PIN 
  stepper.frozen = READ(FREEZE_PIN) == FREEZE_STATE;
#endif

to

#if ENABLED(FREEZE_FEATURE)
  stepper.frozen = READ(FREEZE_PIN) == FREEZE_STATE;
#endif

in MarlinCore.cpp line 491. I assume it was forgotten when "HAS_FREEZE_PIN" was removed

Attached is my config
config.zip

@thisiskeithb
Copy link
Member

Thanks for the report! This will be fixed in #24664

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants