Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Missing "Back" item on Ender 3 Pro #24705

Closed
1 task done
jaevans opened this issue Aug 28, 2022 · 3 comments
Closed
1 task done

[BUG] Missing "Back" item on Ender 3 Pro #24705

jaevans opened this issue Aug 28, 2022 · 3 comments

Comments

@jaevans
Copy link

jaevans commented Aug 28, 2022

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

With latest bugfix-2.1.x custom build for Ender-3 Pro w/Creality 4.7.2 main board the LCD menus have no "back" capability. Looking at the past few days of changes, it looks like commit 2f91154 added a conditional to control the back button. I've checked the Configurations repo for updates around this, but didn't find anything that looks right to me.

For the conditional

#if DISABLED(DISABLE_ENCODER) && ANY(HAS_ROTARY_ENCODER, HAS_ADC_BUTTONS) && ANY(TFT_CLASSIC_UI, TFT_COLOR_UI)

all values are 0 in my config. It seems like HAS_ROTARY_ENCODER and TFT_CLASSIC_UI should be set?

I think I can hack around it for the moment by defining HAS_BACK_ITEM as 1 in my Configuration_adv.h, but I believe this should be on by default.

Looks like it was addressed for some configurations in #24690, but that doesn't fix my setup.

Bug Timeline

new, created by #24618

Expected behavior

Back menu item appears in sub-menus

Actual behavior

No way to go back up the tree

Steps to Reproduce

  1. Compile and flash firmware including commit 2f91154

Version of Marlin Firmware

Bugfix-2.1.x 2022-08-27

Printer model

Creality Ender 3 Pro

Electronics

Creality mainboard 4.2.7

Add-ons

BLtouch

Bed Leveling

UBL Bilinear mesh

Your Slicer

Cura

Host Software

OctoPrint

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

Tried with stock Configuration.h and Configuration_adv.h from Configurations repo with same resul
configuration.zip
t

@EvilGremlin
Copy link
Contributor

EvilGremlin commented Aug 28, 2022

Fixed already, waiting for merge #24694

@thisiskeithb
Copy link
Member

Duplicate of #24689

@thisiskeithb thisiskeithb marked this as a duplicate of #24689 Aug 28, 2022
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants