Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] M115 - badly reported print area dimensions. #25090

Closed
1 task done
rubienr opened this issue Dec 12, 2022 · 1 comment · Fixed by #25092
Closed
1 task done

[BUG] M115 - badly reported print area dimensions. #25090

rubienr opened this issue Dec 12, 2022 · 1 comment · Fixed by #25092

Comments

@rubienr
Copy link
Contributor

rubienr commented Dec 12, 2022

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

The area dimension printed by M115 is badly printed (, and } are missing in the output).

Relates to #22598

See:

SERIAL_ECHOLNPGM(
"area:{"
"full:{"
LIST_N(DOUBLE(NUM_AXES),
"min:{x:", lmin.x, ",y:", lmin.y, ",z:", lmin.z,
",i:", lmin.i, ",j:", lmin.j, ",k:", lmin.k,
",u:", lmin.u, ",v:", lmin.v, ",w:", lmin.w
),
LIST_N(DOUBLE(NUM_AXES),
"max:{x:", lmax.x, ",y:", lmax.y, ",z:", lmax.z,
",i:", lmax.i, ",j:", lmax.j, ",k:", lmax.k,
",u:", lmax.u, ",v:", lmax.v, ",w:", lmax.w
),
"},"
"work:{"
LIST_N(DOUBLE(NUM_AXES),
"min:{x:", wmin.x, ",y:", wmin.y, ",z:", wmin.z,
",i:", wmin.i, ",j:", wmin.j, ",k:", wmin.k,
",u:", wmin.u, ",v:", wmin.v, ",w:", wmin.w
),
LIST_N(DOUBLE(NUM_AXES),
"max:{x:", wmax.x, ",y:", wmax.y, ",z:", wmax.z,
",i:", wmax.i, ",j:", wmax.j, ",k:", wmax.k,
",u:", wmax.u, ",v:", wmax.v, ",w:", wmax.w
),
"}"
"}"
);
#endif

Bug Timeline

tested with bugfix-2.1.x as of version 8298a47

Expected behavior

{
	full: {
		min: {
			x: -1.0000,
			y: -24.0000,
			z: 0.0000
		},
		max: {
			x: 419.0000,
			y: 399.0000,
			z: 431.0000
		}
	},
	work: {
		min: {
			x: 0.0000,
			y: 0.0000,
			z: 0.0000
		},
	        max: {
		        x: 377.0000,
		        y: 370.0000,
		        z: 431.0000
               }
	}
}

Actual behavior

Send: M115
...
Recv: area:{full:{min:{x:-1.0000,y:-24.0000,z:0.0000max:{x:419.0000,y:399.0000,z:431.0000},work:{min:{x:0.0000,y:0.0000,z:0.0000max:{x:377.0000,y:370.0000,z:431.0000}}
...

Formatted area: value:

{
	full: {
		min: {
			x: -1.0000,
			y: -24.0000,
			z: 0.0000
                        # <-- }, missing
		max: {
			x: 419.0000,
			y: 399.0000,
			z: 431.0000
                       # <-- } missing
	},       
	work: {
		min: {
			x: 0.0000,
			y: 0.0000,
			z: 0.0000  
                       # <-- }, missing
		max: {
			x: 377.0000,
			y: 370.0000,
			z: 431.0000
		}
	}
# <-- } missing

Full output (OctoPrint console):

Send: M115
Recv: FIRMWARE_NAME:Marlin bugfix-2.1.x (Nov 26 2022 18:58:23) SOURCE_CODE_URL:github.com/MarlinFirmware/Marlin PROTOCOL_VERSION:1.0 MACHINE_TYPE:Ender-5 Plus - on steroids EXTRUDER_COUNT:2 UUID:3f94418c-877f-4f36-819f-7d419923ccb6
Recv: Cap:SERIAL_XON_XOFF:0
Recv: Cap:BINARY_FILE_TRANSFER:0
Recv: Cap:EEPROM:1
Recv: Cap:VOLUMETRIC:1
Recv: Cap:AUTOREPORT_POS:1
Send: M154 S5
Recv: Cap:AUTOREPORT_TEMP:1
Recv: Cap:PROGRESS:0
Recv: Cap:PRINT_JOB:1
Recv: Cap:AUTOLEVEL:1
Recv: Cap:RUNOUT:1
Recv: Cap:Z_PROBE:1
Recv: Cap:LEVELING_DATA:1
Recv: Cap:BUILD_PERCENT:1
Recv: Cap:SOFTWARE_POWER:1
Recv: Cap:TOGGLE_LIGHTS:1
Recv: Cap:CASE_LIGHT_BRIGHTNESS:1
Recv: Cap:EMERGENCY_PARSER:1
Recv: Cap:HOST_ACTION_COMMANDS:1
Recv: Cap:PROMPT_SUPPORT:1
Recv: Cap:SDCARD:0
Recv: Cap:REPEAT:0
Recv: Cap:SD_WRITE:0
Recv: Cap:AUTOREPORT_SD_STATUS:0
Recv: Cap:LONG_FILENAME:0
Recv: Cap:LFN_WRITE:0
Recv: Cap:CUSTOM_FIRMWARE_UPLOAD:0
Recv: Cap:EXTENDED_M20:0
Recv: Cap:THERMAL_PROTECTION:1
Recv: Cap:MOTION_MODES:1
Recv: Cap:ARCS:1
Recv: Cap:BABYSTEPPING:1
Recv: Cap:CHAMBER_TEMPERATURE:0
Recv: Cap:COOLER_TEMPERATURE:0
Recv: Cap:MEATPACK:1
Recv: Cap:CONFIG_EXPORT:0
Recv: area:{full:{min:{x:-1.0000,y:-24.0000,z:0.0000max:{x:419.0000,y:399.0000,z:431.0000},work:{min:{x:0.0000,y:0.0000,z:0.0000max:{x:377.0000,y:370.0000,z:431.0000}}
Recv: ok P31 B7

Steps to Reproduce

  1. send M115
  2. copy the value of area: and auto-format by jsonlint.com (ignore the missing quotes error)

Version of Marlin Firmware

Marlin bugfix-2.1.x (Nov 26 2022 18:58:23)

Printer model

Creality Ender 5 Plus

Electronics

BTT SKR Pro v1.2

Add-ons

No response

Bed Leveling

UBL Bilinear mesh

Your Slicer

Cura

Host Software

OctoPrint

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

configuration.zip

Additional information & file uploads

No response

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant