-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Simpler distinct firmware rename omits *.bin* #25960
Comments
in the very last line of buildroot/share/Platformio/scripts/marlin.py
is that |
in buildroot/share/Platformio/scripts/offset_and_rename.py
this is a quick fix / bandaid I came up with thats really it. but im sure there is a formal way thats better. |
Fixed in #25966 |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Did you test the latest
bugfix-2.1.x
code?Yes, and the problem still exists.
Bug Description
the terminal outputs the file like this - without the exact label suffix (date/time)
it used to print out like this for example
and when you go see the file in the folder destination - it does not have*
.bin
*, the file name is correct, but there is no type, it is blank.Bug Timeline
No response
Expected behavior
it should be like the previous printout
Actual behavior
does not show firmware-(date/time).bin
and does not have .bin file type in folder.
Steps to Reproduce
the following
default_envs
affected with the recent changeenv:
but may not be limited to these.
Steps To Reproduce:
default_envs =
STM32F103RE_creality or RCBOARD_CREALITY_V4
or similarVersion of Marlin Firmware
Most recent commit firmware rename
Printer model
Voxelab Aquila, ender-3 v2
Electronics
No response
Add-ons
No response
Bed Leveling
None
Your Slicer
None
Host Software
None
Don't forget to include
Configuration.h
andConfiguration_adv.h
.Additional information & file uploads
from the /ini/stm32f.ini* file -
in this code
board_build.rename = firmware-{date}-{time}
i simply put .bin at the end like
and it solved the problem of it not having a .bin type in destination folder, however the other issue of the terminal not printing out the true file name remains.
The text was updated successfully, but these errors were encountered: