Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Auto power loss print resume with temperature limitation #26528

Closed
vovodroid opened this issue Dec 14, 2023 · 3 comments · Fixed by #26649
Closed

[FR] Auto power loss print resume with temperature limitation #26528

vovodroid opened this issue Dec 14, 2023 · 3 comments · Fixed by #26649
Labels
F: Print Recovery T: Feature Request Features requested by users.

Comments

@vovodroid
Copy link
Contributor

vovodroid commented Dec 14, 2023

Is your feature request related to a problem? Please describe.

Currently after power loss and restart printer sometimes ask confirmation for resume (M1000 S), and sometimes continue automatically (M1000) - https://github.com/search?q=repo%3AMarlinFirmware%2FMarlin+%22M1000&type=code It's hard coded for different cases (screen types?).

Confirmation approach could cause resume delay, until bed is cooled too much so model can not be further printed due adhesion loss.
Auto approach could resume printing when bed is cool and it's already too late to resume, thus causing double loss of filament.

For instance ASA on glass bed almost losses adhesion under 90-80 deg.C.

Are you looking for hardware support?

No response

Describe the feature you want

I would suggest to add resume temperature threshold parameter, with meaning to resume printing if temperature if more than threshold, and cancel (or ask) if it's already cooler.

Logic example is something like this:

void GcodeSuite::M1000() {

  if (recovery.valid()) {
     bool force_resume    = false;

     if (thermalManager.degBed() >= 90)
        force_resume = true;

    if (parser.seen_test('S') && !force_resume) {

Setting threshold to something high (or -1, or adding additional flag) will trigger current behavior. Such parameters could be define in config_adv.h, or dynamic EEPROM parameters.

If such change is welcome I could work on it.

Additional context

No response

@vovodroid vovodroid added the T: Feature Request Features requested by users. label Dec 14, 2023
@vovodroid
Copy link
Contributor Author

I tried to implement it in https://github.com/vovodroid/Marlin/commits/auto_resume_bed_temp/

Could it become base for PR?

@thisiskeithb
Copy link
Member

Closing since you’ve opened a PR.

Copy link

github-actions bot commented Mar 9, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F: Print Recovery T: Feature Request Features requested by users.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants