Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define OpenLineageResource(OpenLineageService) constructor #1868

Closed
wslulciuc opened this issue Feb 8, 2022 · 1 comment
Closed

Define OpenLineageResource(OpenLineageService) constructor #1868

wslulciuc opened this issue Feb 8, 2022 · 1 comment
Labels
api API layer changes feature

Comments

@wslulciuc
Copy link
Member

When constructing a new OpenLineageResource object, a ServiceFactory is required therefore not allowing users to inject, possibly their own, OpenLineageService implementation. Let's define the constructor OpenLineageResource(OpenLineageService) and deprecate the usage of OpenLineageResource(ServiceFactory).
@wslulciuc wslulciuc added feature api API layer changes labels Feb 8, 2022
@fm100
Copy link
Collaborator

fm100 commented Feb 8, 2022

Every resources inherits BaseResource with a constructor getting ServiceFactory, and we may want to do some overall refactoring to create resourses only with the actual dependencies to be injected.

@pawel-big-lebowski pawel-big-lebowski mentioned this issue May 30, 2023
Merged
7 tasks
@github-project-automation github-project-automation bot moved this to Done in Marquez Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api API layer changes feature
Projects
Marquez
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fm100 @wslulciuc