-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use traits instead of structs #5
Comments
I have been thinking about changing this in a 2.x branch. However, it has implications in the performance if In the first version of the library I used this structs to simplify the interface and because all genotypes are arrays of things. What structs are you thinking about and what are their cases of use? A possible use that I though was using Thanks. |
Maybe what I want to do is out of the scope of this framework. I will clone it and try to adapt it. Then we'll see |
Feel free to fork and create pull requests. If they are interesting can be merged into this project. Anyway, a 2.x branch will be created in the following months, with more flexibility and other improvements. Regards. |
Do you mean there is already some work going on for this 2.x version? How can I know what are the improvements of this? Regards. |
Yes, I have been working in some ideas and implementations, but nothing has been pushed yet because I am experimenting and trying to get better results and performance. The improvements are:
These improvements are focused in find multiple solutions and exploring different search space areas. Other improvements in which I have thinking (but not started) are:
I have not worked on this for some weeks, but I expect releasing a new branch during summer. |
Half of this is done by simply adding one trait bound |
I had tried using |
2.0 version is more flexible than 1.x, but I have not made Maybe a future major version of Oxigen will apply this changes. |
The Genotype iter and into_iter methods should return a Type that implements the Iterator and IntoIterator traits and not the specific implementation of these traits for slices.
This would improve usability of the framework
The text was updated successfully, but these errors were encountered: