feat: Remove unused legacy methods and refactor project #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed methods that handle project hash addition and lookup in various classes. Major refactor on RemoteProject, removing methods for adding and retrieving commit hashes. Affected classes include ProjectRepository, ProjectDaoConverter, BadSmellGraphQLTest, and others. Streamlined the handling of projects in the system.
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2023.3.0
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
The 'getRecent' method was removed from both ProjectRepository and SqlProjectRepository because it is no longer necessary. The corresponding test for 'getRecent' was also removed from SqlProjectRepositoryTest.
The ProjectRepository dependency has been removed from the SpoonPeriodicMiner class. The changes also reflect on the constructor, where 'projectRepository' is no longer required as an argument.
|
This PR is 41.00294985250738% new code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed methods that handle project hash addition and lookup in various classes. Major refactor on RemoteProject, removing methods for adding and retrieving commit hashes. Affected classes include ProjectRepository, ProjectDaoConverter, BadSmellGraphQLTest, and others. Streamlined the handling of projects in the system.