Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update LiveViewPage layout and adjust AnalyzerRuns fetch method #1405

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

MartinWitt
Copy link
Owner

The layout for the LiveViewPage in the frontend has been updated to include a PageLayout component. It also now logs the received data. In the backend, the fetchAnalyzerRuns method in the MiningGraphQL class has been slightly altered. The SQL query LIMIT clause has been removed from the find method string argument and implemented instead as method argument via the page method for better readability and maintainability.

The layout for the LiveViewPage in the frontend has been updated to include a PageLayout component. It also now logs the received data. In the backend, the fetchAnalyzerRuns method in the MiningGraphQL class has been slightly altered. The SQL query LIMIT clause has been removed from the find method string argument and implemented instead as method argument via the page method for better readability and maintainability.
Copy link

gitstream-cm bot commented Dec 26, 2023

This PR is 60% new code.

Copy link
Contributor

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.3.0
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@MartinWitt MartinWitt merged commit d01d7a9 into master Dec 26, 2023
10 checks passed
@MartinWitt MartinWitt deleted the fix/livefeed branch December 26, 2023 09:08
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant