Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove all QODANA rules and corresponding tests #1457

Merged
merged 4 commits into from
Jan 14, 2024

Conversation

MartinWitt
Copy link
Owner

No description provided.

The commit deletes multiple 'xyz/keksdose/spoon/code_solver' QODANA rules files. Those include AnalyzerResultVisitor.java, CodeBlock2Expr.java, InnerClassMayBeStatic.java, MethodMayBeStatic.java, NonProtectedConstructorInAbstractClass.java and more. It implies that the corresponding code analysis behavior that each rule corresponds to has been deprecated or replaced by other logic. Additionally, related test files were also removed.
Copy link

@gitstream-cm gitstream-cm bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains a TODO statement. Please check to see if they should be removed.

Copy link
Contributor

github-actions bot commented Jan 14, 2024

Qodana Community for JVM

1 new problem were found

Inspection name Severity Problems
String concatenation as argument to 'StringBuilder.append()' call 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.3.0
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

gitstream-cm bot commented Jan 14, 2024

This PR is 10.17210377600822% new code.

@MartinWitt MartinWitt merged commit fcdde5b into master Jan 14, 2024
7 of 11 checks passed
@MartinWitt MartinWitt deleted the feat/removeQodana/1 branch January 14, 2024 01:23
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant