-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.4.5 does not kill openocd process anymore after pressing stop button #493
Comments
Yes, some changes have occurred in 0.4.5 that could affect this. Can you give me some details?
You can revert to 0.4.4 -- VSCode extension manager lets you do this but then you may get stuck at that version. It is better to help me fix the issue, but you decide |
Of course:
I just compiled openocd to see if that helps. launch.json
After pressing F5, openocd is launched and debugging works as expected. Pressing the Stop button stops it, but openocd still runs in the background. So next invokation via F5 fails because openocd is already running. Setting `request' to attach does not help in this regard. |
Ok, that helps. We will try to reproduce this. |
Hello, |
I am able to duplicate this problem. Unfortunately, it works fine when I launch the extension within a debugger but the production version fails. Investigating... Basically, I cannot debug my own extension, so I have to try other ways. |
There is now a new release. Hopefully, this is fixed. I was able to duplicate/fix this on both Mac and Linux |
It may take a while for VSCode marketplace to push the release. You can pickup the latest from https://github.com/Marus/cortex-debug/releases/tag/V0.4.6 and install the VSIX file manually in VSCode. Do not double click on it. Use VSCode for the installation. |
Anyone following this thread, please confirm if the problem is fixed after installing 0.4.6 |
I installed 0.4.6 and had a look. In |
It quits fine for me on Windows/Mac/Linux with either attach or launch. I have a feeling this is VSCode exiting/killing our debug extension before we had a chance to cleanup ... because it is taking too long. I have pretty fast machines though, but not sure that has an effect. Will try another approach. |
Can you try our new approach. We install a gdb disconnect even handler in OpenOCD to auto shutdown when gdb disconnects. This should happen every time now, attach or launch does not matter. https://github.com/Marus/cortex-debug/releases/tag/V0.4.7-pre2 |
This look good. I tried in |
1 similar comment
This look good. I tried in |
We are experiencing this issue now with v0.4.7, @sourcebox does it work for you? |
@AndriiLishchynskyi I cannot duplicate this with 0.4.7 on either Windows or Mac, launch or attach, stop or disconnect. What platform? Now I am wondering if VSCode is killing us before we have a chance to clean up. Did not try Linux. |
Sorry for missing details. It was identified at least on two machines: macOS BigSur 11.6 and macOS Catalina 10.15.7. |
After a conversation with @haneefdm it turned out that the problem was in my launch.json. Thanks a lot for identifying the the root cause! |
Hi! Could you elaborate on what exactly was the problem. I'm experiencing exactly the same issue now, would appreciate some help. |
It would be helpful if you tell me what version you are using, a copy of your launch.json, etc. You are commenting on a closed issue. Please open a new issue if it is happening with the latest 1.2.0 |
Hi! I switched OpenOCD from v0.10 to v0.11, and the problem dissapeared completely. |
So I have to kill it manually from the terminal everytime after a launch. If this is caused by some new feature or configuration setting, please provide detailed information how to restore the previous behaviour.
The text was updated successfully, but these errors were encountered: