App crash on completion block to unowned self

[steviemo]

Hey thanks for the awesome library!

I have uncovered an issue though in my app where I require to reload a view (which contains a few checkbox) in quick succession. My app is crashing at line 127 in the M13CheckboxStrokeController.swift:

CATransaction.setCompletionBlock({ [unowned self] () -> Void in
    self.resetLayersForState(self.state)
    completion?()
    })

Should self not be weak with null checks on self? If you agree I could submit a PR for the fix ASAP. I'd say it would be safer to update the three completion blocks in this class from unowned to weak so handle the checkbox being created and destroyed quickly.

Thanks,
Stephen

[steviemo]

Just an FYI I made the changes to weak self and everything working as expected.

[gverdouw]

I'm hitting the same issue in my own app

[ke7insud]

I am still getting this issue. It has not been fixed.

[fjsosa]

Same issue here

[andreaantonioni]

I just merged a PR that fixes this #121 and I'll publish a new version with this fix

[tnmendes]

I am using the last version M13Checkbox (3.4.0) and is happening the same issue.
This error is happening when I am doing the animation but before it finished I press a button to popToRooViewController.

} else {
            let fromPath = pathGenerator.pathForMark(fromState)
            let toPath = pathGenerator.pathForMark(toState)
            
            let morphAnimation = animationGenerator.morphAnimation(fromPath, toPath: toPath)
            
            CATransaction.begin()
            CATransaction.setCompletionBlock({ [unowned self] () -> Void in
                self.resetLayersForState(self.state)
                completion?()
                })
            
            markLayer.add(morphAnimation, forKey: "path")
            
            CATransaction.commit()
        }

on line 145:
self.resetLayersForState(self.state)
Thread 1: EXC_BREAKPOINT (code=1, subcode=0x1c053daf4)