fix(oauth2) security fixes #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ALTER TABLE oauth2_authorization_codes ADD COLUMN credential_id uuid REFERENCES oauth2_credentials (id) ON DELETE CASCADE; | ||
| ]], | ||
| down = [[ | ||
| ALTER TABLE jwt_secrets DROP COLUMN credential_id; |
subnetmarco
force-pushed
the
fix/oauth2-security
branch
from
a3e6f67 to
31d0f2b
Compare
| { | ||
| name = "2016-07-15-oauth2_code_credential_id", | ||
| up = [[ | ||
| TRUNCATE oauth2_authorization_codes; |
There was a problem hiding this comment.
Is that not an issue for current production instances?
There was a problem hiding this comment.
Authorization codes are different than access tokens. They are supposed to be consumed immediately and they expire after 5 minutes. Not a big deal.
|
Just making sure. Ok then |
subnetmarco
added
pr/ready (but hold merge)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix involves a migration of the database to support an additional
credential_idcolumn in theoauth2_authorization_codestable.