Skip to content

Commit

Permalink
In-memory nested archives
Browse files Browse the repository at this point in the history
alpha-linuxecoff has compressed archives that are decompressed to a
bfd-in-memory.  We'd need to handle quite a lot of corner cases to
support nesting of such archives, so just stop it before we run into
segfaults later.

	* opncls.c (_bfd_new_bfd_contained_in): Prohibit nested
	archives in memory.
  • Loading branch information
amodra committed Feb 20, 2023
1 parent 9a7f501 commit c50e4ce
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions bfd/opncls.c
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,12 @@ _bfd_new_bfd_contained_in (bfd *obfd)
{
bfd *nbfd;

/* Nested archives in bims are unsupported. */
if ((obfd->flags & BFD_IN_MEMORY) != 0)
{
bfd_set_error (bfd_error_malformed_archive);
return NULL;
}
nbfd = _bfd_new_bfd ();
if (nbfd == NULL)
return NULL;
Expand Down

0 comments on commit c50e4ce

Please sign in to comment.