-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSP as export format for MassBank-data #132
Comments
Really appreciated! |
Somewhat related ... @adelenelai shared this earlier today They do not yet seem to support MSP (on a superficial look) but maybe an extension? |
Jep, They are part of NFDI4chem. |
I usually use http://prime.psc.riken.jp/compms/others/main.html#Massbank2msp (usually followed by the LIB2Nist to convert it to a NIST library). This works quite well with the appropriate settings. But possibly @meier-rene has something better? |
IIRC Massbank2msp is a windows program, so it would not work nicely in a continuous integration pipeline. Correct ? |
Github should provide a Windows based runner... However, it might be a nicer way to write an own parser. The format is super simple and this should be doable in some hours: NAME: Mellein; LC-ESI-ITFT; MS2; CE |
The tool of Riken is obviously not running in command line mode and thus no chance for automation. Hence, an offline workaround and using a runner mode is not possible. :-( |
At one point I started (with @michaelwitting and @Treutler) work on a converter that uses schema templates, so it would read/write arbitrary formats by just adding new templates. I still find the idea neat but we never really materialized the thing. A simple MSP writer is easier to do, of course. |
Another initiative (which can still use the schema template idea) is Also note that we have started to document parts of the MassBank environment Yours, Steffen |
Really appreciated :-) Best, |
@meowcat Indeed, this is something we should follow up. Maybe the |
Nice, but we need a |
@meier-rene has now worked on an export for MSP that will appear in our releases. Yours, Steffen |
By today, this appeared! Many thanks to @meier-rene for your efforts! https://github.com/MassBank/MassBank-data/releases/tag/2020.11 Time to close this issue. |
Reopen... It is a pity that the original record number is not included and we should give some credits to the authors. Could be parsed to the comment field. |
I will include this. Thanks for the comment. This converter to MSP is pretty new, so I expect some more issues. Please don't hesitate to report them. |
Yep. First, thanks a ton! Second, the original accession ID would be really great. Then finally, not essential but worth a thought, the MSP format used by NIST (which I consider "the reference") uses a mixture of CamelCase (
In the further future, we could also include the peak annotations. We once compiled correspondence between record format fields here, maybe that helps: |
@tsufz Your issue is solved. I uploaded a RIKEN msp version which includes a DB id. @meowcat The first msp I uploaded was not in the NIST format, but the RIKEN format. I've chosen this because its more used in our place, but I don't want to argue which one is the reference ore more useful. Our converter can also create NIST dialect of msp and thats why I also uploaded a NIST format msp. Future releases will include both version, but I will not implement a third version. 😄 Your record format cheat sheet will become useful in the future. Thank you for sharing! I would appreciate it, if it would stay accessible. |
Hi, in addition to #31 and #32 we can think about
*.msp
as export format for the releases. @meier-rene has code
up the sleeve that exports MB records to some flavour of
*.msp
files.Yours, Steffen
The text was updated successfully, but these errors were encountered: