We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In heat_transfer.finite_line_source, the integrand function includes a sum of integrals of the error function :
heat_transfer.finite_line_source
pygfunction/pygfunction/heat_transfer.py
Lines 288 to 294 in 66d8b4c
The sum can be vectorized as follows :
if reaSource and imgSource: # Full (real + image) FLS solution p = np.array([1, -1, 1, -1, 1, -1, 1, -1]) q = np.stack([D2 - D1 + H2, D2 - D1, D2 - D1 - H1, D2 - D1 + H2 - H1, D2 + D1 + H2, D2 + D1, D2 + D1 + H1, D2 + D1 + H2 + H1], axis=-1) f = lambda s: 0.5 / (H2*s**2) * np.exp(-dis**2*s**2) * np.inner(p, _erfint(q*s))
This should be more efficient and save some calculation especially for smaller bore fields.
The text was updated successfully, but these errors were encountered:
Same test cases as in #78.
Sorry, something went wrong.
MassimoCimmino
Successfully merging a pull request may close this issue.
In
heat_transfer.finite_line_source
, the integrand function includes a sum of integrals of the error function :pygfunction/pygfunction/heat_transfer.py
Lines 288 to 294 in 66d8b4c
The sum can be vectorized as follows :
This should be more efficient and save some calculation especially for smaller bore fields.
The text was updated successfully, but these errors were encountered: