Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish on release workflow #230

Closed
j-c-cook opened this issue Aug 16, 2022 · 4 comments · Fixed by #243
Closed

Publish on release workflow #230

j-c-cook opened this issue Aug 16, 2022 · 4 comments · Fixed by #243
Milestone

Comments

@j-c-cook
Copy link
Contributor

Did version 2.2.0 never get pushed onto PyPi? Would you want to setup a publish on release workflow file? I remember thinking pre-releases don't trigger this workflow.

@j-c-cook j-c-cook changed the title Version 2.2.0 on PyPi Publish on release workflow Aug 16, 2022
@MassimoCimmino
Copy link
Owner

This is odd. I am fairly certain I uploaded it and tested the installation using pip. I will upload it today.

A workflow file would definitely streamline the release process and avoid this kind of mistake in the future.

@MassimoCimmino
Copy link
Owner

I just published v2.2.0.

This issue can be used to implement the workflow. There will be some differences with ghedt since we do not have a setup.py file anymore for pygfunction.

@MassimoCimmino
Copy link
Owner

This looks like a good place to start : https://github.com/pypa/gh-action-pypi-publish

@j-c-cook
Copy link
Contributor Author

This is odd. I am fairly certain I uploaded it and tested the installation using pip. I will upload it today.

A workflow file would definitely streamline the release process and avoid this kind of mistake in the future.

Perhaps PyPi had to roll back a version, lost some data in the process and you were lucky enough to get in at the wrong time. A workflow can't help with that, but most of the time should reduce some of the manual input required to get a release out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants