Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private repos using github oauth tokens #387

Closed
vektah opened this issue Apr 19, 2016 · 3 comments
Closed

Private repos using github oauth tokens #387

vektah opened this issue Apr 19, 2016 · 3 comments

Comments

@vektah
Copy link

vektah commented Apr 19, 2016

In dev ssh keys are usually used to allow access to private repos, but in CI it can be a pain to manage ssh keys for github machine users with limited access.

I propose adding support for github oauth (https+basic auth). These oauth key works as the password, and can be managed at https://github.com/settings/tokens.

As a bonus, if an oauth key ever gets committed to a public repo github will revoke it automatically.

eg:

glide get https://<username>:<token>@github.com/myorg/privaterepo

would fetch the git repo by doing:

git clone https://<username>:<token>@github.com/myorg/privaterepo

and the glide.yaml would look like:

import:
  - name: https://<username>:<token>@github.com/myorg/privaterepo
@mattfarina
Copy link
Member

@vektah Handling this well in a CI system is important to me.

First, imports can have alternative VCS information. For example,

import:
- package: github.com/myorg/privaterepo
  repo:  https://<username>:<token>@github.com/myorg/privaterepo

This should work today. For the package at that location locally the repo used will be the one here.

But, a glide.yaml file checked into a project really shouldn't have credentials in it. This is just not a good idea for securely storing those credentials.

Instead, we need a way to supply overriding aliases that the CI system can supply with credentials. The CI system can securely store them. See #39, #372, and #380 to see where this is going. I'd like to have the alias system in place soon.

What do you think?

@vektah
Copy link
Author

vektah commented Apr 19, 2016

Ah thanks, that's perfect for now.

Big ol' 👍 to the .gliderc idea, its in line with how other dependency managers work. Its great to see that there is some thought going into this.

I'll close this as there seem to be other tickets covering the ongoing work.

@vektah vektah closed this as completed Apr 19, 2016
@thanasisk
Copy link

Are there any updates on this topic as I really need oath token support for github (as generated by Personal Access Tokens")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants