Skip to content

RandomAlphaNumeric and CryptoRandomAlphaNumeric are not as random as they should be

Low
technosophos published GHSA-xg2h-wx96-xgxr Feb 4, 2021

Package

No package listed

Affected versions

< 1.0.2

Patched versions

1.0.2

Description

Impact

A security-sensitive bug was discovered by Open Source Developer Erik Sundell of Sundell Open Source Consulting AB.

The functions RandomAlphaNumeric(int) and CryptoRandomAlphaNumeric(int) are not as random as they should be. Small values of int in the functions above will return a smaller subset of results than they should. For example, RandomAlphaNumeric(1) will always return a digit in the 0-9 range, while RandomAlphaNumeric(4) will return around ~7 million of the ~13M possible permutations.

This is considered a security release because programs that rely upon random generators for passwords are at an increased risk of brute force-style password guessing. There is also a higher probability of collision.

The problem was the result of a mistaken regular expression that only accepted random strings if they contained a digit from [0-9]. That restriction has been removed.

Patches

This issue has been corrected in v1.0.2.

Workarounds

If you cannot upgrade to v1.0.2, you can work around the issue by calling RandomAlphaNumericCustom(N, true, true)|CryptoRandomAlphaNumericCustom(N, true, true) instead. (Where N is the desired length, and true is the literal boolean true.)

Severity

Low

CVE ID

No known CVE

Weaknesses

No CWEs