New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Struct Version has methods on both value and pointer receivers. Such usage is not recommended by the Go Documentation #237

Open

grosser opened this issue May 21, 2024 · 1 comment · May be fixed by #240

Contributor

grosser commented May 21, 2024

want to fix that or there is a good reason for it ?

Member

mattfarina commented Jun 4, 2024

Good catch. This is some debt that has come in over time with various pull requests and have not been good checking for it. Very open to fixing this.

grosser linked a pull request

that will close this issue

change Version to only have pointer receivers #240

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment