Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCS-74: Add +build tags to tests, to allow selectively running suites for different VCSs #74

Open
m0j0hn opened this issue Apr 17, 2017 · 3 comments

Comments

@m0j0hn
Copy link
Contributor

m0j0hn commented Apr 17, 2017

As a developer, I would like to be able to selectively run tests, so I do not test code I did not modify.

As a developer, I would like to be able to selectively run tests, so I do not need to install tools I do not normally use (BZR, SVN, et al) just so I can get tests to pass when testing locally.

AC: "+build" tags added to *_test.go files, and CI config files to test all by default.

@m0j0hn m0j0hn changed the title Add +build tags to tests, to allow selectively running suites for different VCSs VCS-74: Add +build tags to tests, to allow selectively running suites for different VCSs Apr 17, 2017
@dmitshur
Copy link

This has the tradeoff that running go test will no longer run all tests, is that right?

@m0j0hn
Copy link
Contributor Author

m0j0hn commented Apr 18, 2017

yes, that is correct -
this SO article is my reference on this: http://stackoverflow.com/questions/24030059/skip-some-tests-with-go-test
I'm not totally happy that it "does nothing by default", but the alternative seems to be adding "!nameX" to every "*_test.go" that is not "nameX_test.go", which gets really bad when adding new "nameX" modules, for new values X - if that makes sense.

@m0j0hn
Copy link
Contributor Author

m0j0hn commented Apr 21, 2017

@mattfarina @technosophos Can you please consider this Issue and the PR for its fix?
#75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants