Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please pick the version you prefer for Coq 8.20 in Coq Platform 2025.01 #15

Closed
MSoegtropIMC opened this issue Dec 5, 2024 · 11 comments
Closed

Comments

@MSoegtropIMC
Copy link

The Coq team released Coq 8.20.0 on September 3rd, 2024.
The corresponding Coq Platform release 2025.01 should be released before Jan 31st, 2025.
It can be delayed in case of difficulties until Feb 28th, 2025, but this should be an exception.

This issue is to inform you that the opam package we are currently testing in Coq Platform CI works fine with Coq 8.20.0.

Coq Platform CI is currently testing opam package coq-libhyps.2.0.8
from official repository https://coq.inria.fr/opam/released/packages/coq-libhyps/coq-libhyps.2.0.8/opam.

In case this is the version you want to see in Coq Platform, there is nothing to do for you - please just close this issue.

In case you would prefer to see an updated or an older version in the upcoming Coq Platform 2025.01, please inform us as soon as possible and before Dec 31st, 2024!

The working branch of Coq Platform, can be found here main.
It contains package pick ~8.20~2025.01 which already supports Coq version 8.20.0 and contains already working (possibly patched / commit pinned) Coq Platform packages.

In case you want to select a different version, please don't close this issue, even after creating the new tag and/or opam package.
We will close the issue after updating Coq Platform.
This is a measure of 'double book keeping' in order to avoid that we ship the wrong version.

In any case, Coq Platform won't be released before this issue is closed!

Thanks!

P.S.: this issue has been created automatically based on CI status.

CC: coq/platform#449

@MSoegtropIMC
Copy link
Author

@Matafou : in case coq-libhyps.2.0.8 is the version you would like to see in Coq Platform 2025.01, can you please close this issue?

@Matafou
Copy link
Owner

Matafou commented Dec 18, 2024

I am currently working on a new version. How much time do I have please?

@Matafou
Copy link
Owner

Matafou commented Dec 18, 2024

Ho I see there is a date in your initial message sorry.

@MSoegtropIMC
Copy link
Author

For packages no other packages depends on mid of January is just fine. This is enough head room to do the release by end of January.

@Matafou
Copy link
Owner

Matafou commented Dec 19, 2024

Hi @MSoegtropIMC Can you update all version to libhyps.3.0.1 please? I updated the coq-libhyps.opam.

Question: Is there a way to test my coq-libhyps.opam without creating a tag and waiting for coq platform to do its CI? I am polluting my tag history with countless wrong attempts :-(

@Matafou
Copy link
Owner

Matafou commented Dec 19, 2024

Actually 8.18 and 8.19 would also benefit from this update. No big deal.

@MSoegtropIMC
Copy link
Author

Coq Platform comes with a local patch opam repo - this is always registered with the opam switches Coq Platform creates. You can just put your opam file in the correct folder under https://github.com/coq/platform/tree/main/opam/opam-coq-archive/released/packages und update the version picked for your package in the pick file https://github.com/coq/platform/blob/main/package_picks/package-pick-8.20~2025.01.sh. Then you run the coq platform make script and answer the questions.

It does make sense to do a full build or extended build because having additional packages can change things. For a quick test you can just do a base build in install your package via opam - it will still use your local package as long as the coq platform switch is selected. You can also just delete packages from the pick file you do not want to build.

I should add a proper readme for this.

For 8.19 I plan to do an updated pick, for 8.18 likely not.

@Matafou
Copy link
Owner

Matafou commented Dec 19, 2024

Hmm thanks. Not sure to know how to do that.
I will provide a pull request for libhyps-3.0.1.

@MSoegtropIMC
Copy link
Author

It sounds more complicated than it is. If the risk is small, it is indeed best to just do the PR and see what the Coq Platform CI says after I updated.

As I said, I will add docs.

@Matafou
Copy link
Owner

Matafou commented Dec 19, 2024

PR submitted. Tests seem OK.

@MSoegtropIMC
Copy link
Author

I updated Coq Platform to use coq-libhyps version 3.0.1 via coq/platform#454 => closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants