Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

canary-cloud: Use Redpanda Cloud #29195

Merged
merged 1 commit into from
Aug 28, 2024
Merged

canary-cloud: Use Redpanda Cloud #29195

merged 1 commit into from
Aug 28, 2024

Conversation

def-
Copy link
Contributor

@def- def- commented Aug 22, 2024 •
edited
Loading

Fixes: https://github.com/MaterializeInc/cloud/issues/9721

Nightly run: https://buildkite.com/materialize/nightly/builds/9274

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@def- def- force-pushed the pr-ci-redpanda branch 2 times, most recently from ff31fce to 579c2cb Compare August 23, 2024 16:57
@def- def- changed the title WIP: Redpanda Cloud in CI canary-cloud: Use Redpanda Cloud Aug 23, 2024
@def- def- force-pushed the pr-ci-redpanda branch 8 times, most recently from 2f70b17 to 6b0dfa5 Compare August 26, 2024 16:05
@def- def- force-pushed the pr-ci-redpanda branch 4 times, most recently from c8bf04a to 3457c38 Compare August 26, 2024 16:41
benesch
benesch reviewed Aug 26, 2024
View reviewed changes
Copy link
Member

@benesch benesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic, @def-—thank you!

We can only run one cloud canary test with Redpanda Cloud at a time, right? Should we create a new pipeline ("Expensive nightly"? "External services nightly"?) so that folks using trigger-ci don't run this test when validating a PR?

@def-
Copy link
Contributor Author

def- commented Aug 26, 2024

This is already only executed on main and release branches, and also locked by using a concurrency group. So no problem for PRs.

@def- def- force-pushed the pr-ci-redpanda branch 3 times, most recently from 3d43a4d to d6c3792 Compare August 26, 2024 22:10
@benesch
Copy link
Member

benesch commented Aug 27, 2024

Ah, beautiful! Well this basically LGTM. Are you still working to get it to pass nightlies? Let me know when you're ready for a full review (and how thorough of a review you feel you need).

@def- def- marked this pull request as ready for review August 27, 2024 06:34
@def- def- requested a review from a team as a code owner August 27, 2024 06:34
@def-
Copy link
Contributor Author

def- commented Aug 27, 2024 •
edited
Loading

Ah, beautiful! Well this basically LGTM. Are you still working to get it to pass nightlies?

It worked before, I broke it again by some refactoring. Hopefully the new run is green now: https://buildkite.com/materialize/nightly/builds/9274
If not, should only be some minor changes required. So this should be ready for review.
Edit: Succeeded now.

@def- def- force-pushed the pr-ci-redpanda branch 2 times, most recently from e265de5 to cf57d50 Compare August 27, 2024 08:56
@def- def- force-pushed the pr-ci-redpanda branch 3 times, most recently from 3757a55 to d2ab409 Compare August 27, 2024 11:31
@def- def- force-pushed the pr-ci-redpanda branch 2 times, most recently from 8fb3287 to 47e0e1a Compare August 27, 2024 15:23
@def- def- enabled auto-merge August 27, 2024 15:24
@def- def- requested a review from benesch August 27, 2024 15:24
@def- def- disabled auto-merge August 27, 2024 15:24
benesch
benesch approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@benesch benesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic work, Dennis—thank you so much!

@def- def- merged commit 7f409e5 into MaterializeInc:main Aug 28, 2024
63 of 86 checks passed
@def- def- deleted the pr-ci-redpanda branch August 28, 2024 07:02
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benesch benesch benesch approved these changes

@bobbyiliev bobbyiliev Awaiting requested review from bobbyiliev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@def- @benesch