Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common rules for inclusion and querying #210
Common rules for inclusion and querying #210
Changes from 10 commits
aef2e4d
39b78d6
65de03c
746a4d8
2a393f0
724f6f7
2b61396
ade5532
39d3b85
f29f48b
c69d5f0
947a0b6
502bd44
892f60a
8a6a4b2
55f542e
dc9befc
43295c4
e39ed9f
172f33e
b247be2
256ac70
c8e9a92
8f02b7f
d6a4aff
1d768c5
5033820
543b0fc
1d6a210
ad01ba2
3f1c5e0
fe86cd4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I presume it is intentional to leave out the conditional here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. The intent was to simplify the rules for inclusion/exclusion of properties. Also I had PR #206 in mind while developing the current PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've deleted this for some that are OPTIONAL in the response, but not all. How do you justify this? Or rather, what is the implication?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. I was a little hesitant to cleanup the requirements, but I think with the addition of general clarification in 502bd44 the rest of the optional clauses can be removed. Did so in 8a6a4b2 and 892f60a.