Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#80 Prepare Frontend project structure #81

Merged
merged 4 commits into from
Mar 21, 2021
Merged

#80 Prepare Frontend project structure #81

merged 4 commits into from
Mar 21, 2021

Conversation

DomiZet
Copy link
Contributor

@DomiZet DomiZet commented Mar 19, 2021

No description provided.

PiotrRynio
PiotrRynio reviewed Mar 20, 2021
View reviewed changes
Copy link
Collaborator

@PiotrRynio PiotrRynio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prosze o odpowiedź na pytania :)

frontend/package.json Show resolved Hide resolved
frontend/public/index.html Show resolved Hide resolved
frontend/src/components/FooTouer/FooTouer.css Outdated Show resolved Hide resolved
frontend/src/index.tsx Show resolved Hide resolved
frontend/src/index.tsx Show resolved Hide resolved
frontend/src/components/FooTouer/FooTouer.tsx Show resolved Hide resolved
MateuszNaKodach
MateuszNaKodach approved these changes Mar 20, 2021
View reviewed changes
Copy link
Owner

@MateuszNaKodach MateuszNaKodach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dobra robota, jedynie chciałbym podjąć świadoma decyzję o tym pliku z env :)

@PiotrRynio
Copy link
Collaborator

A czy nie lepiej zostawić App.js? Nazwa aplikacji może się zmienić zawsze.

PiotrRynio
PiotrRynio reviewed Mar 20, 2021
View reviewed changes
frontend/src/components/FooTouer/FooTouer.css Outdated Show resolved Hide resolved
frontend/public/index.html Show resolved Hide resolved
frontend/src/components/FooTouer/FooTouer.css Outdated Show resolved Hide resolved
PiotrRynio
PiotrRynio reviewed Mar 20, 2021
View reviewed changes
Copy link
Collaborator

@PiotrRynio PiotrRynio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nazwa błędna

frontend/src/index.tsx Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #81 (564e6b9) into develop (f6be045) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #81   +/-   ##
========================================
  Coverage    85.33%   85.33%           
========================================
  Files          166      166           
  Lines         1896     1896           
  Branches       154      154           
========================================
  Hits          1618     1618           
  Misses         275      275           
  Partials         3        3
Flag Coverage Δ
backend 85.33% <ø> (ø)
integrationtests 85.33% <ø> (ø)
unittests 85.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6be045...564e6b9. Read the comment docs.

@DomiZet DomiZet merged commit c5f1a40 into develop Mar 21, 2021
@MateuszNaKodach MateuszNaKodach deleted the #80_Prepare_Frontend_project_structure branch March 23, 2021 10:47
MateuszNaKodach added a commit that referenced this pull request Mar 24, 2021
@DomiZet @MateuszNaKodach
#80 Prepare Frontend project structure (#81)
7e08318 
* #80 Prepare Frontend project structure

* Delete all style from FooTouer.css file

Co-authored-by: Mateusz Nowak <kontakt.mateusznowak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiotrRynio PiotrRynio PiotrRynio left review comments

@MateuszNaKodach MateuszNaKodach MateuszNaKodach approved these changes

@PawelSzambelan PawelSzambelan PawelSzambelan approved these changes

@tomaszdworniczak tomaszdworniczak Awaiting requested review from tomaszdworniczak

@annalamperska annalamperska Awaiting requested review from annalamperska

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DomiZet @PiotrRynio @codecov-io @MateuszNaKodach @PawelSzambelan