Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suspicious that custom data conserved attribute not being set #208

Open
rheiland opened this issue Feb 9, 2024 · 2 comments
Open

suspicious that custom data conserved attribute not being set #208

rheiland opened this issue Feb 9, 2024 · 2 comments

Comments

@rheiland
Copy link
Collaborator

rheiland commented Feb 9, 2024

https://github.com/MathCancer/PhysiCell/blob/master/core/PhysiCell_cell.cpp#L3039

@MathCancer
Copy link
Owner

Thanks!

conserved is by default false. That is, it is treated as a heritable parameter, and any daughter cells inherit the same value. (unlike a conserved quantity, which is split between daughter cells.)

When parsing XML, if the XML attribute isn't found, pugi::xml_node.attribute(string).as_bool() returns false, so a false would be overwritten with a false (no problem).

If the attribute is found, then false is overwritten by false or true, and both of these are no problem.

@MathCancer
Copy link
Owner

Now I think I better understand your comment, and I think you're 100% right.

NOw I understand that 3039 is not the bug, but instead that conserved isn't used at https://github.com/MathCancer/PhysiCell/blob/master/core/PhysiCell_cell.cpp#L3077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants