Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saving rules v1 instead of v2 to /output #225

Open
rheiland opened this issue Apr 14, 2024 · 3 comments
Open

saving rules v1 instead of v2 to /output #225

rheiland opened this issue Apr 14, 2024 · 3 comments

Comments

@rheiland
Copy link
Collaborator

https://github.com/MathCancer/PhysiCell/blob/master/core/PhysiCell_rules.cpp#L2356

setup_cell_rules() is calling export_rules_csv_v1( rules_file );

@drbergman
Copy link
Collaborator

drbergman commented Apr 25, 2024

I believe that means that it also prints the base value, correct? Which I find useful.

// output the rule
fs << cell_type << "," << signal << "," << response << "," << behavior << "," // 0,1,2,3
<< base_value << "," << max_response << "," << half_max << "," << hill_power << "," // 4,5, 6,7,
<< use_for_dead << std::endl; // 8

@rheiland
Copy link
Collaborator Author

Hmm, fair point. Just don't try to import that v1 version of the rules in the current version (2.37.*) of the Studio. I guess we should allow for importing v1 rules, but presumably we would also want to check the base value there with what the Studio currently has.

@elmbeech
Copy link
Contributor

elmbeech commented Jun 8, 2024

this is related to issue #256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants