Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend automated tests for NodeConnection #216

Closed
Tracked by #310
joshuakarp opened this issue Jul 22, 2021 · 4 comments · Fixed by #310
Closed
Tracked by #310

Extend automated tests for NodeConnection #216

joshuakarp opened this issue Jul 22, 2021 · 4 comments · Fixed by #310
Assignees
@tegefaulkes
Labels
development Standard development epic Big issue with multiple subissues

Comments

@joshuakarp
Copy link
Contributor

Specification

Some extra functionality has been brought into NodeConnection from !195. Tests need to be added for them.

Tasks

Add tests for:

  1. getRootCertChain/getExpectedPublicKey
  2. getChainData
@joshuakarp joshuakarp added the development Standard development label Jul 22, 2021
@joshuakarp
Copy link
Contributor Author

Given the refactoring that will be undertaken in #225, this will be part of that issue.

@joshuakarp joshuakarp added epic Big issue with multiple subissues and removed epic Big issue with multiple subissues labels Nov 29, 2021
@joshuakarp
Copy link
Contributor Author

The testing required from this issue will likely change as a result of the refactoring in #225. The aim is for NodeConnection to be quite a lightweight class, without a lot of redundant and repeated implementation details (most of this should be found and testing in GRPCClientAgent). Therefore, will need to readdress this after the refactoring in #225.

@joshuakarp joshuakarp added the epic Big issue with multiple subissues label Dec 20, 2021
@CMCDragonkai CMCDragonkai mentioned this issue Jan 9, 2022
Merged
46 tasks
@CMCDragonkai
Copy link
Member

What additional automated tests were done for this? @tegefaulkes @joshuakarp. Please elaborate based on #310.

@tegefaulkes
Copy link
Contributor

This was just covered by the general test updates when working in #310, tests for the functions listed in the description above were added as well as any other missing tests. I can add some more details if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tegefaulkes tegefaulkes

Labels
development Standard development epic Big issue with multiple subissues
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extracting Node Connection Management out of NodeManager to NodeConnectionManager MatrixAI/Polykey
3 participants
@CMCDragonkai @tegefaulkes @joshuakarp